To: jon miner In-Reply-To: <4.2.0.58.19990817115936.00a6c4c0(null)> Cc: Vim Developers List Subject: patch 5.4.32 (was: Possible bug in src/Makefile (patch attached)) Fcc: outbox From: Bram Moolenaar ------------ Jon Miner wrote: > I discovered what may be a bug in src/Makefile.. > > When running ./configure in src, LDFLAGS should be passed in, like it is > for cflags.. This breaks my machine (NetBSD) where ncurses is installed in > /usr/pkg/lib. You are right. For running configure for ctags, LDFLAGS is passed already. I don't expect passing LDFLAGS to configure to cause a problems, so let's just add it. Patch 5.4.32 Problem: Unix: $LDFLAGS was not passed to configure. Solution: Pass $LDFLAGS to configure just like $CFLAGS. (Jon Miner) Files: src/Makefile *** ../vim-5.4.31/src/Makefile Sun Jul 25 13:18:43 1999 --- src/Makefile Tue Aug 17 21:18:28 1999 *************** *** 1166,1172 **** # config config.mk: configure GUI_INC_LOC="$(GUI_INC_LOC)" GUI_LIB_LOC="$(GUI_LIB_LOC)" \ ! CC="$(CC)" CFLAGS="$(CFLAGS)" \ $(CONF_SHELL) ./configure $(CONF_OPT_GUI) $(CONF_OPT_X) \ $(CONF_OPT_PERL) $(CONF_OPT_PYTHON) $(CONF_OPT_TCL) \ $(CONF_OPT_CSCOPE) $(CONF_OPT_MULTIBYTE) $(CONF_OPT_INPUT) \ --- 1173,1179 ---- # config config.mk: configure GUI_INC_LOC="$(GUI_INC_LOC)" GUI_LIB_LOC="$(GUI_LIB_LOC)" \ ! CC="$(CC)" CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" \ $(CONF_SHELL) ./configure $(CONF_OPT_GUI) $(CONF_OPT_X) \ $(CONF_OPT_PERL) $(CONF_OPT_PYTHON) $(CONF_OPT_TCL) \ $(CONF_OPT_CSCOPE) $(CONF_OPT_MULTIBYTE) $(CONF_OPT_INPUT) \ *** ../vim-5.4.31/src/version.h Tue Aug 17 17:45:38 1999 --- src/version.h Tue Aug 17 21:18:41 1999 *************** *** 19,26 **** #define VIM_VERSION_MINOR_STR "4" #define VIM_VERSION_BUILD 57 #define VIM_VERSION_BUILD_STR "57" ! #define VIM_VERSION_PATCHLEVEL 31 ! #define VIM_VERSION_PATCHLEVEL_STR "31" /* * VIM_VERSION_NODOT is used for the runtime directory name. --- 19,26 ---- #define VIM_VERSION_MINOR_STR "4" #define VIM_VERSION_BUILD 57 #define VIM_VERSION_BUILD_STR "57" ! #define VIM_VERSION_PATCHLEVEL 32 ! #define VIM_VERSION_PATCHLEVEL_STR "32" /* * VIM_VERSION_NODOT is used for the runtime directory name. *************** *** 30,35 **** */ #define VIM_VERSION_NODOT "vim54" #define VIM_VERSION_SHORT "5.4" ! #define VIM_VERSION_MEDIUM "5.4.31" ! #define VIM_VERSION_LONG "VIM - Vi IMproved 5.4.31 (1999 Aug 17)" ! #define VIM_VERSION_LONG_DATE "VIM - Vi IMproved 5.4.31 (1999 Aug 17, compiled " --- 30,35 ---- */ #define VIM_VERSION_NODOT "vim54" #define VIM_VERSION_SHORT "5.4" ! #define VIM_VERSION_MEDIUM "5.4.32" ! #define VIM_VERSION_LONG "VIM - Vi IMproved 5.4.32 (1999 Aug 17)" ! #define VIM_VERSION_LONG_DATE "VIM - Vi IMproved 5.4.32 (1999 Aug 17, compiled " -- hundred-and-one symptoms of being an internet addict: 116. You are living with your boyfriend who networks your respective computers so you can sit in separate rooms and email each other --/-/---- Bram Moolenaar ---- Bram@moolenaar.net ---- Bram@vim.org ---\-\-- \ \ www.vim.org/iccf www.moolenaar.net www.vim.org / /